fix: exit edit mode when navigating between tabs in Agreement details#5630
Open
fix: exit edit mode when navigating between tabs in Agreement details#5630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
useEffectinAgreement.jsxthat watcheslocation.pathnameand resetsisEditModetofalsewhen the user navigates between tabs — mirroring the pattern inCan.hooks.js.useNavigationBlockermodal still intercepts tab clicks when there are real unsaved changes, so the save/discard/cancel flow is unaffected.Issue
#5565
How to test
/agreements/:id?mode=edit→ Agreement Details opens in edit modeA11y impact
A11Y-SUPPRESSIONmetadata (owner, expires, rationale)Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist