fix(can-funding): serialize pending actions to preserve history ordering#5631
Draft
johndeange wants to merge 6 commits intomainfrom
Draft
fix(can-funding): serialize pending actions to preserve history ordering#5631johndeange wants to merge 6 commits intomainfrom
johndeange wants to merge 6 commits intomainfrom
Conversation
…correct display of events
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaces the parallel
Promise.allSettledsave strategy inCanFunding.hooks.jswith a sequentialpendingActionsqueue that dispatches mutations in the exact order the user took them in the UI. This fixes issue #5571, where budget and funding-received mutations raced on the client, causing the backend to record history events in non-deterministic order.frontend/src/pages/cans/detail/CanFunding.hooks.jsPendingActiontype and exportedmergePendingActionutility that collapses redundant queue entries (e.g., repeated budget edits, edit-then-delete of a staged row)pendingActionsstate;handleAddBudget,handleAddFundingReceived, anddeleteFundingReceivednow enqueue typed actionssaveChangesto iterate the queue sequentially with afor...of/switchdispatch, preserving user-intended orderingfrontend/src/pages/cans/detail/CanFunding.hooks.test.js.unwrap()pattern matching the new sequential callsfrontend/cypress/e2e/canFundingHistoryOrdering.cy.js(new)frontend/cypress.config.js/cypress.config.ci.jsIssue
#5571
How to test
Unit tests:
E2E test (requires Docker stack running):
Manual verification:
A11y impact
Screenshots
N/A — no visual changes; behavior fix only affects mutation ordering and history display sequence.
Definition of Done Checklist
Links
N/A