-
Notifications
You must be signed in to change notification settings - Fork 49
Feature file - Search functions #7556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Feature file - Search functions
| @@ -0,0 +1,24 @@ | |||
| @7079 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can do that.
| And I see 'text' at dialog | ||
| |text| | ||
| |This search query was copied to your clipboard. Paste it as a link anywhere.| | ||
| Then I see 'clipboard' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what this means - can we verify that the correct url is pasted when the user does a "paste" after clicking "copy"?
| And I click 'hyperlink' | ||
| | hyperlink | | ||
| | Test-2-Test save search | | ||
| Then I see 'search parameter' section populated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we test the display for all filter options, as well as sort order, not just the search query?
| |Must include all words (ex. transportation AND safety)| | ||
|
|
||
| @login @PendingAutomate | ||
| Scenario: Verify no search term entered when switching from AND to OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Scenario: Verify no search term entered when switching from AND to OR | |
| Scenario: Verify no change occurs when no search term entered and switching from AND to OR | |
| When I select 'May include any words (ex. transportation OR safety)' at 'search-verb-switch' | ||
| And I enter 'Research Scientist' at 'Search' field | ||
| And I click 'Search' button | ||
| Then I see each entry in 'Search Results' section contains 'Research' OR 'Scientist' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is going to be difficult to verify, since our search function looks at the opportunity description, and all other opportunity metadata to determine matches. If you can put some time in to a test case that is somewhat easier to verify as far as the difference between and AND based and OR based search that would be good. You could also pinpoint particular opportunities that will appear in an OR case but not an AND case and assert on that. If it's not really possible or reliable enough of a test case, it might be enough to assert that the number of results is different between the two cases
| Scenario: Verify search result count when switching from AND to OR | ||
| When I enter 'K01 Mentored Research Scientist' at 'Search' field | ||
| And I click 'Search' button | ||
| And I see '9' at 'Search Results' section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these numbers will change over time. Probably best to assert that the number for an AND search will always be less than or equal to the number for an OR search
| | 15 | | ||
|
|
||
| @login @PendingAutomate | ||
| Scenario: Verify search result count remains the same when no search term entered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem like a useful test case
| | 1000+ | | ||
|
|
||
| @login @PendingAutomate | ||
| Scenario Outline: Verify search result when search with arithmetic operators when switching from AND to OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this testing? We won't expect users to use these sorts of search terms, but maybe bots will?
Feature file - Search functions
Summary
Fixes / Work for #4076, #7079
Changes proposed
Context for reviewers
Validation steps