[Issue #7380] Conditionally disable radio buttons based off status #7716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmurdock/7380-conditionally-disable-radio update logic to disable radio button when application status is submitted
hayeshorus
requested review from
ErinPattisonNava,
andycochran,
btabaska,
chay-REIsys,
doug-s-nava and
myduong-navapbc
as code owners
hayeshorus
requested review from
glenblosser-nava and
nathan-stricker
as code owners
hmurdock/7380-conditionally-disable-radio updated tests to add application status information to test classes
…ithub.com/HHS/simpler-grants-gov into hmurdock/7380-conditionally-disable-radio
hmurdock/7380-conditionally-disable-radio updated test logic
hmurdock/7380-conditionallyu-disable-radio prettier updates for failing tests
hmurdock/7380-conditionally-disable-radio updated test logic for failing tests
hayeshorus
removed request for
andycochran,
btabaska,
chay-REIsys,
doug-s-nava,
glenblosser-nava and
nathan-stricker
Collaborator
|
Not sure what happened, but it seems that the PR template got confused? Can you put it back? It should list either fixes or work, not both. That determines if UAT in needed. For this PR, since it is a bug, UAT isn't required. The name of the PR needs to follow |
frontend/src/components/application/IncludeFormInSubmissionRadio.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/application/IncludeFormInSubmissionRadio.test.tsx
Show resolved
Hide resolved
hmurdock/7380-conditionally-disable-radio updated to use object and updated tests
hmurdock/7380-conditionally-disable-radio updated tests and fixes to snapshot
…onally-disable-radio
hmurdock/7380-conditionally-disable-radio updated lint fixes
hmurdock/7380-conditionally-disable-radio format-check fixes for prettier
hayeshorus
changed the title
hayeshorus
changed the title
frontend/src/components/application/ApplicationValidationAlert.test.tsx
Outdated
Show resolved
Hide resolved
hmurdock/7380-conditionally-disable-radio updated tests and format adding back needed parameters
hmurdock/7380-conditionally-disable-radio updated code for format check errors
Collaborator
ErinPattisonNava
left a comment
ErinPattisonNava
left a comment
There was a problem hiding this comment.
All the forms show up both under the required list and the conditional list, regardless of whether they are conditional or required.
| <h3>{t("requiredForms")}</h3> | ||
| <ApplicationTable | ||
| forms={forms} | ||
| applicationForms={requiredForms} |
Collaborator
There was a problem hiding this comment.
Note that this is just the required forms.
Collaborator
Author
There was a problem hiding this comment.
ok, then forms only required will show, else nothing will show?
| </p> | ||
| <ApplicationTable | ||
| forms={forms} | ||
| applicationForms={conditionalRequiredForms} |
Collaborator
There was a problem hiding this comment.
And this is supposed to just be the conditional forms
hmurdock/7380-conditionally-disabled-radio added back in application forms and updated tests
hmurdock/7380-conditionally-disable-radio updated compile error
…ithub.com/HHS/simpler-grants-gov into hmurdock/7380-conditionally-disable-radio
hmurdock/7380-conditionally-disable-radio updated formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work for #7109
Changes proposed
Updated logic when application status is submitted radio buttons are disabled
"Submit with Application" radio should be conditionally disabled
screenshot of html page for docraptor
Changes proposed
Added logic to conditionally disable radio buttons when application status is submitted
Validation steps