[Issue #7336] Handle unauthorized exceptions in getApplicationDetails… #7749
+186
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add unit tests
chay-REIsys
requested review from
ErinPattisonNava,
andycochran,
btabaska,
doug-s-nava,
glenblosser-nava,
myduong-navapbc and
nathan-stricker
as code owners
…mock function results
doug-s-nava
reviewed
Jan 5, 2026
Collaborator
doug-s-nava
left a comment
doug-s-nava
left a comment
There was a problem hiding this comment.
love the new tests - please keep any of these that are relevant even if the PR doesn't end up making any changes to the fetchers
| @@ -0,0 +1,185 @@ | |||
| import { | |||
| tags: [`application-${applicationId}`, "application-details"], | ||
| }, | ||
| }); | ||
| try { |
Collaborator
There was a problem hiding this comment.
The most correct fix for this issue, I'm realizing, is to wrap this page in an AuthorizationGate component. This would mean a pretty sizeable refactor of the existing page, and the application page needs that work done as well. I can make a separate ticket for you to pick up as a follow up to implement that.
For now, can you follow the pattern that exists on the application page, and add the try catch logic within the page component, where the call to the fetch function is being made, and return the <TopLevelError> if an error occurs?
… in getApplicationDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes / Work for #7336
Changes proposed
get Application Details is included in try catch to handle exceptions much better
added unit tests for the method
Context for reviewers