Fix/test pollution and math animator#393
Open
zbinxp wants to merge 2 commits intoHKUDS:mainfrom
Open
Conversation
The test mock for _cli_kit was missing the `spinner` entry, causing ImportError when start_tour.py tried to import it. Also adds SCRIPTS_ROOT to sys.path so _cli_kit can be resolved when imported from the scripts/ subdirectory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The _install_module helper in test_capabilities_runtime.py was creating a brand-new ModuleType for deeptutor.services.config, wiping out existing submodules like context_window_detection. This caused downstream tests to fail with AttributeError when they tried to import from that submodule. Also fixes math_animator capability: extract answer_now_context from config_overrides before validating, since it is a transport wrapper field not a MathAnimatorRequestConfig field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix pytest failures
Fix 1 — tests/core/test_capabilities_runtime.py — _install_module now copies existing attributes from the real module before applying test-specific overrides, preventing submodules like context_window_detection from being wiped out.
Fix 2 — deeptutor/capabilities/math_animator.py — answer_now_context is now extracted from config_overrides before validation, since MathAnimatorRequestConfig has extra="forbid" and rejects unknown fields.
Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Add any other context or screenshots about the pull request here.