fix Update qdrant_impl.py #1253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielaskdd
requested changes
Apr 5, 2025
lightrag/operate.py
Outdated
| @@ -998,7 +998,7 @@ async def get_kg_context(): | |||
|
|
|||
| async def get_vector_context(): | |||
| # Consider conversation history in vector search | |||
| augmented_query = query | |||
| augmented_query = f"Instructions: Based on the user query, provide a list of relevant documents that are most likely to contain the answer to the user's query.\nQuery: {query}" | |||
There was a problem hiding this comment.
@LarFii Please review whether the changes here are reasonable.
There was a problem hiding this comment.
oh I forgot to exclude that part . that doesn't relate to the main issue. i'm using an instruct version of the e5 model and that format is required for it to function properly. I hope there's a higher level config that allows user to easily do that without modifying the internal module.
|
Thanks for sharing. Kindly resolve the conflicts and exclude changes to |
towpi13
commented
Apr 8, 2025
|
please merge main branch and resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this solve the issue #909 related to get_func_id
Related Issues
this should also solve this issue #1144
Changes Made
I just added the missing functions in the QdrantVectorDBStorage class
Checklist
Additional Notes
[Add any additional notes or context for the reviewer(s).]