fix: preserve cached xlsx formula values#3375
Open
eteriall wants to merge 1 commit into
Open
Conversation
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve XLSX extraction so formula cells preserve their indexable content.
Previously, formula cells could be indexed as the formula text itself (e.g.
=SUM(A1:A10)) instead of the computed value when parsing spreadsheets. This meant documents containing formulas sometimes lost meaningful searchable content if the workbook values weren't handled correctly.This change makes the extractor prefer cached calculated values when they are available, while falling back to the formula text when a workbook has not been recalculated and no cached value exists.
Related Issues
None.
Changes Made
_extract_xlsxto read cached workbook values and formula text together.Checklist
Additional Notes
On same files - graph before fix
Chat before fix
Graph after fix
Chat after fix