[codex] Pass proxy environment to CCXT loader#126
Draft
ruok808 wants to merge 1 commit into
Draft
Conversation
f7d1066 to
4faf216
Compare
Collaborator
|
Thanks for the focused fix. I reviewed the diff and the approach looks reasonable to me. I also verified the declared regression suite locally: python -m pytest agent/tests/test_ccxt_loader_proxy.py agent/tests/test_ccxt_loader_bounded.py agent/tests/test_get_market_data_unresolved.py -qResult: One small process note: this PR is still marked as Draft, so we cannot treat it as ready to merge yet. When you are ready, please mark it as ready for review. After that I think this should be straightforward to merge. Optional follow-up, not a blocker: it would be nice to add one more regression covering explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxiesconfig to CCXT so public exchange data can be fetched from restricted networks.ALL_PROXYand for the no-proxy case.Why
Requests-based loaders already inherit proxy environment variables, but CCXT does not reliably do so through this loader's current constructor path. In restricted network environments, Binance/OKX public market data can time out unless the proxy is passed explicitly to CCXT.
This change only uses environment variable names and never logs proxy values or credentials.
Tests
Result:
13 passed.