Fix agent session history loading#136
Merged
Merged
Conversation
warren618
force-pushed
the
codex/fix-agent-session-loading
branch
from
6d42e66 to
eadcbc8
Compare
Collaborator
|
@fightZy Thanks for the fix! Merged. I rebased the branch onto the latest main to resolve the Agent.tsx conflict from the newer goal workflow, kept your authorship on the commit, and verified the frontend build passes. Great catch on the stale generation/loading skeleton issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Opening an existing Agent session can leave the conversation area stuck on loading skeletons in development. The session-loading effect increments its generation counter on every effect run, so a no-op rerun can mark the in-flight history request as stale before it clears the loading state.
Changes