Fix support for SSH-style Git URLs (fixes #1204)#1205
Open
vadi2 wants to merge 1 commit intoHL7:masterfrom
Open
Fix support for SSH-style Git URLs (fixes #1204)#1205vadi2 wants to merge 1 commit intoHL7:masterfrom
vadi2 wants to merge 1 commit intoHL7:masterfrom
Conversation
Add handling for SSH-style Git URLs like git@github.com:org/repo.git in getURLWithNoUserInfo(). These URLs are not valid according to java.net.URL parsing, but are safe to return as-is since they don't contain embedded credentials (they use SSH keys). The fix adds a regex check to detect SSH URL format before attempting standard URL parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling for SSH-style Git URLs like git@github.com:org/repo.git in getURLWithNoUserInfo(). These URLs are not valid according to java.net.URL parsing, but are safe to return as-is since they don't contain embedded credentials (they use SSH keys).
The fix adds a regex check to detect SSH URL format before attempting standard URL parsing.