Skip to content

Do not warn about unresolved CQL Library reference if the canonical is rooted in example.org#1253

Merged
grahamegrieve merged 2 commits intoHL7:masterfrom
cqframework:master
Feb 28, 2026
Merged

Do not warn about unresolved CQL Library reference if the canonical is rooted in example.org#1253
grahamegrieve merged 2 commits intoHL7:masterfrom
cqframework:master

Conversation

@brynrhodes
Copy link
Copy Markdown
Contributor

No description provided.

@qligier
Copy link
Copy Markdown
Contributor

qligier commented Feb 20, 2026

This could benefit from a bit of refactoring, since multiple places in the code treat different sets of domains as example.

XIGLoader only considers example.org, but BaseValidator considers example.{org,com,net} and acme.{com,org} (plus some OIDs).

@richardtownleyoneill-ADHA
Copy link
Copy Markdown

There are other example URLs: example.com, example.net. See https://www.iana.org/help/example-domains

@brynrhodes
Copy link
Copy Markdown
Contributor Author

Okay, generalized a bit to handle any example domain and refactored to a Utilities class. That class should be moved somewhere but I wasn't sure what the best place for that would be, so I left it in CqlSubsystem for now.

Copy link
Copy Markdown
Contributor

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grahamegrieve grahamegrieve merged commit fe51fdb into HL7:master Feb 28, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in IG Publisher issue board Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants