Skip to content

Fix NPE in PublicationChecker when publication-request.json is absent#1294

Merged
grahamegrieve merged 1 commit intomasterfrom
jct-fix-npe
Apr 22, 2026
Merged

Fix NPE in PublicationChecker when publication-request.json is absent#1294
grahamegrieve merged 1 commit intomasterfrom
jct-fix-npe

Conversation

@costateixeira
Copy link
Copy Markdown
Collaborator

When an IG has been previously published (canonical serves a valid package-list.json) but the local repo has no publication-request.json, checkExistingPublication NPE'd on pr.has("movedFrom").

This treats pr == null as "no movedFrom declared" and fall through to the normal publication-comparison branch.

Copy link
Copy Markdown
Contributor

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grahamegrieve grahamegrieve merged commit e5bfdec into master Apr 22, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in IG Publisher issue board Apr 22, 2026
@grahamegrieve grahamegrieve deleted the jct-fix-npe branch April 22, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants