Datatypes#4126
Open
bvdh wants to merge 20 commits into
Open
Conversation
- Replaced broken literal timezone extension text in datatypes instant value-domain note - Applied required extension anchor format using [%extensions-location%]StructureDefinition-timezone.html - Kept implementation scope to fhir-fork/source/datatypes.html only
- Replace Primitive Types placeholder with a concrete 4-column primitive table - Keep primitive names as plain text and retain compact `def` links to datatypes.html anchors - Add/retain required primitive anchor names used by table entries for fragment navigation
- Update code primitive regex in datatypes source to the approved expression - Align the [%regex code%] source value with ^[^\s]+(\s[^\s]+)*$ - Keep scope limited to a single source definition row in primitives.xml
- Update code primitive regex in datatypes source to the approved expression - Align the [%regex code%] source value with ^[^\s]+( [^\s]+)*$ - Keep scope limited to a single source definition row in primitives.xml
- update the Duration drt-1 FHIRPath expression in duration.xml - update the Duration drt-1 XPath expression to match the same semantics - restore the FHIR-28415 value-implies-code semantics for Duration - add UCUM system/code in example Duration instances impacted by drt-1 - reference historical fixes from c999cee and 0fa9bbb
- Clarified SampledData datatype description to state lowerLimit/upperLimit are measured and not scaled - Added explicit unscaled wording for SampledData.lowerLimit detection bound text - Added explicit unscaled wording for SampledData.upperLimit detection bound text
- Clarified id primitive description to explicitly prohibit all whitespace characters - Added matching id datatype clarification in datatypes narrative and notes - Verified id regex and [%regex id%] token wiring remain unchanged
- Add endOffset column to the Timing criteria examples table - Correct "Every second day" and "Every second day starting on Day 2" values to avoid every-day semantics - Add explicit endOffset example for a 28-day cycle with a 7-day off interval
- Clarify that Attachment.url relative references resolve against the FHIR service base URL - Add explicit relative vs absolute example (Patient/123 vs full http URL)
- Add comparator code ~ to the QuantityComparator code list in datatypes/quantity.xml - Update Quantity.comparator allowed-code hint text to include ~ - Clarify Quantity.comparator narrative wording to include approximately equal semantics
- Allow SampledData to have interval and/or offsets instead of requiring XOR - Clarify that interval applies when offsets run out - Relax offsets data-count rule when interval is present
- Add Timing notes section for periods with start or end offsets - Point startOffset and endOffset comments to the new notes section - Align offset narrative with period-required and effective-period semantics
- Clarified SampledData datatype and lower/upper limit definitions to use scaled semantics (factor + origin) - Added explicit lowerLimit and upperLimit guidance: scale like data values, then multiply by factor and add origin - Added approved guidance for differing dimensions: use multiple SampledData instances (typically per Observation.component)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
One or more commits addressing the tickets listed below.
Per-Ticket Change Summary
Notes on Overlaps