Skip to content

security/consent/FHIR-53886 and FHIR-54155#4198

Open
mojitoj wants to merge 3 commits into
masterfrom
security-consent-FHIR-54155-6
Open

security/consent/FHIR-53886 and FHIR-54155#4198
mojitoj wants to merge 3 commits into
masterfrom
security-consent-FHIR-54155-6

Conversation

@mojitoj

@mojitoj mojitoj commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

HL7 FHIR Pull Request

FHIR-53886
FHIR-54155

Description

Clarify all the policy elements and their relationships.

@mojitoj mojitoj self-assigned this Jun 21, 2026
@mojitoj mojitoj force-pushed the security-consent-FHIR-54155-6 branch from 21c828e to 024c5c9 Compare June 21, 2026 23:05
@mojitoj mojitoj changed the title Security consent fhir 54155 6 security/consent/FHIR-53886 and FHIR-54155 Jun 21, 2026
@mojitoj mojitoj marked this pull request as ready for review June 22, 2026 17:02
@mojitoj mojitoj temporarily deployed to claude-triage June 22, 2026 17:02 — with GitHub Actions Inactive
@mojitoj mojitoj force-pushed the security-consent-FHIR-54155-6 branch from 024c5c9 to 6491970 Compare June 22, 2026 17:03
@mojitoj mojitoj temporarily deployed to claude-triage June 22, 2026 17:15 — with GitHub Actions Inactive

@lmckenzi lmckenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. source/consent/consent-introduction.xml line ~46: "The regulatoryBasis elements is used to record*,** the broad jurisdictional or organizational policy…"* — should be element is, and the comma after "record" looks misplaced.
  2. Line ~54: "to adjudicate whether the consent permits a specific activity such a sharing a particular part of patient information…" — should be such as.
  3. Line ~70: "The policyBasis element, if present, is intended to captures the higher-level policy…" — should be to capture.
  4. Line ~40: a <ul> is placed directly inside a <p> (<p>… <ul>…</ul> </p>). Strict XHTML doesn't permit block-level content inside <p>; worth checking it still validates against fhir-xhtml.xsd, and if so, consider closing the <p> before the list and opening a new one after.

@mojitoj mojitoj force-pushed the security-consent-FHIR-54155-6 branch from 6491970 to 5b37bc3 Compare June 23, 2026 16:57
@mojitoj mojitoj temporarily deployed to claude-triage June 23, 2026 17:12 — with GitHub Actions Inactive
@mojitoj mojitoj requested a review from lmckenzi June 23, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants