Skip to content

peer review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soloshadow wants to merge 2 commits into
base: master
Choose a base branch
from
Open

peer review #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d96800
Merge remote-tracking branch 'refs/remotes/HLA-systeem/master'
Soloshadow Jun 9, 2017
8470afa
reviewed code
Soloshadow Jun 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,14 @@ Used basically everywhere.
## UML
https://github.com/HLA-systeem/ToUncurseWeRequireaRumor/blob/master/UML_To_Uncurse_We_Require_a_Rumor.pdf

Beoordeling =>

Er is gebruikt gemaakt van en static util method in de constants java class.
Scene interface en de classes die scenes implementeren zitten in scenes folder
Duidelijk gebruikt gemaakt van encapsulation, inheritance, composition
Player class is een singleton in de vorm van => public static synchronized Player getInstance() methode
Strategy pattern zit er ook in managers folder in scenes

Ik geef de game een voldoende. Codes waren goed gestructureerd en leesbaar voor mij. Het heeft alle onderdelen toegepast.
Verbeterpunt is om wel wat meer comments te gebruiken om de functie van de classes beter uit te leggen voor mensen die niet zo goed zijn in android.