Skip to content

微软账号皮肤相关修改#3858

Closed
CiiLu wants to merge 68 commits into
HMCL-dev:mainfrom
CiiLu:skin
Closed

微软账号皮肤相关修改#3858
CiiLu wants to merge 68 commits into
HMCL-dev:mainfrom
CiiLu:skin

Conversation

@CiiLu

@CiiLu CiiLu commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Close #3486
Close #3633
Close #3410

内容：

  • 微软账户皮肤增加3D预览
  • 支持修改披风
  • 皮肤上传增加模型选择
image image

@burningtnt burningtnt mentioned this pull request Apr 26, 2025
Closed
@Wulian233

Wulian233 commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

需要至少实现简中和英语的翻译

> Task :checkTranslations FAILED
I18N.properties missing key 'account.skin.upload'
FAILURE: Build failed with an exception.
I18N.properties missing key 'account.skin.select_model'

I18N.properties missing key 'account.cape.none'
* What went wrong:
I18N.properties missing key 'account.cape.change'
Execution failed for task ':checkTranslations'.
I18N_zh.properties missing key 'account.cape.none'
> Part of the translation is missing
I18N_zh.properties missing key 'account.cape.change'

@3gf8jv4dv

3gf8jv4dv commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

需要至少实现简中和英语的翻译

I18N_zh.properties 是繁体中文。此外构建时要求简繁英都要有对应翻译。

@3gf8jv4dv

3gf8jv4dv commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

考虑为披风名添加翻译吗？

3gf8jv4dv
3gf8jv4dv suggested changes Apr 26, 2025
View reviewed changes
Comment thread HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N.properties
Comment thread HMCL/src/main/resources/assets/lang/I18N.properties
@CiiLu @3gf8jv4dv
Apply suggestions from code review
40d40b3 
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
@burningtnt

burningtnt commented Apr 28, 2025

Copy link
Copy Markdown
Member

若要加入披风选择功能，应直接在启动器内加入数个披风的贴图以允许玩家可视化地选择披风

@burningtnt

burningtnt commented Sep 29, 2025

Copy link
Copy Markdown
Member

请解决冲突

3gf8jv4dv
3gf8jv4dv reviewed Oct 3, 2025
View reviewed changes

@3gf8jv4dv 3gf8jv4dv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

希望能重新排序一下 i18n 文件中「account」部分的字符串顺序，所有条目按字母排序。

@CiiLu

CiiLu commented Dec 20, 2025

Copy link
Copy Markdown
Contributor Author

将拆分到几个独立PR

@CiiLu CiiLu closed this Dec 20, 2025
@CiiLu CiiLu deleted the skin branch January 1, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Wulian233 Wulian233 Wulian233 left review comments

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv requested changes

@burningtnt burningtnt burningtnt requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@CiiLu @Wulian233 @3gf8jv4dv @burningtnt @zkitefly