使用 @Language 注解#3907
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the regex pattern definitions by removing redundant Pattern.compile() calls and instead uses string literals annotated with @language for regex injection. The changes simplify and centralize regex initialization in both CrashReportAnalyzer and LibraryAnalyzer.
- Replace inline Pattern.compile() calls with string literals.
- Annotate regex inputs with @language and compile them within the constructor.
- Update affected enum constructors accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/game/CrashReportAnalyzer.java | Simplified regex initialization in Rule enum by using string literals instead of Pattern.compile calls. |
| HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java | Updated LibraryType constructor and enum constants to use string literals for regex patterns with proper @language annotation. |
Glavo
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用 https://www.jetbrains.com/help/idea/using-language-injections.html 功能,以移除重复的
Pattern.compile声明