优化模组管理页面模组信息的展示方式#4621
Merged
Merged
Conversation
Member
Glavo
commented
Oct 6, 2025
Glavo
commented
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request optimizes the display of mod information in the mod management page by refactoring how mod data is stored and presented to users.
- Simplified the ModInfoObject class by removing redundant fields and computed properties
- Updated mod display logic to prioritize translated names when available
- Enhanced file name display to show actual file names instead of mod names
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
如果要将中文翻译默认显示在 title 上，建议合并该 pr 就就优化翻译匹配，否则会出现翻译错误误导的问题 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
不妨增加一个选项：mod列表高级菜单 |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
我更偏向这个PR提供的UI：
|
Member
Author
|
我又调整了一下显示方式。
|
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
也许可以增加一个显示项：如果模组支持的minecraft版本与当前实例不匹配则显示警告或者将版本tag标红 |
Member
|
突然想到，如果模组中含有 信雅互联 时，建议禁用不兼容警告 |
Member
Author
这个在考虑中，但 HMCL 现在无法识别信雅互联等使用 jarinjar 的模组，所以需要我们修复后才能支持。 |
This was referenced Oct 9, 2025
OrzMiku
reviewed
Dec 20, 2025
| root.getStyleClass().add("no-padding"); | ||
| listView = new JFXListView<>(); | ||
|
|
||
| this.holder = FXUtils.onWeakChange(skinnable.loadingProperty(), loading -> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.