检测到系统 zlib 实现为 zlib-ng 时跳过 Forge/NeoForge 安装时的哈希检测#6068
Conversation
… verification for dynamically generated JARs
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a ZlibUtils utility to detect if the system's zlib implementation produces standard compressed output. This is used to prevent installation failures in ForgeNewInstallTask when alternative libraries like zlib-ng cause SHA-1 mismatches in dynamically generated JARs; in such cases, the system now falls back to a structural integrity check. Review feedback suggests avoiding wildcard imports in Launcher.java, using case-insensitive comparisons for file extensions, and declaring the IS_ZLIB_COMPATIBLE flag as final.
| import org.jackhuang.hmcl.util.FileSaver; | ||
| import org.jackhuang.hmcl.util.Lang; | ||
| import org.jackhuang.hmcl.util.StringUtils; | ||
| import org.jackhuang.hmcl.util.*; |
There was a problem hiding this comment.
建议避免使用通配符导入（wildcard import）。根据 Google Java 编程风格指南以及本项目现有的代码风格，应当使用具体的类导入，以提高代码的可读性并避免潜在的命名冲突。
| import org.jackhuang.hmcl.util.*; | |
| import org.jackhuang.hmcl.util.CrashReporter; | |
| import org.jackhuang.hmcl.util.FileSaver; | |
| import org.jackhuang.hmcl.util.Lang; | |
| import org.jackhuang.hmcl.util.StringUtils; | |
| import org.jackhuang.hmcl.util.ZlibUtils; |
| } | ||
|
|
||
| if (!Objects.equals(code, entry.getValue())) { | ||
| if (!ZlibUtils.IS_ZLIB_COMPATIBLE && FileUtils.getExtension(artifact).equals("jar")) { |
There was a problem hiding this comment.
检查文件扩展名时，建议使用不区分大小写的比较（如 equalsIgnoreCase），以确保在处理具有大写扩展名（如 .JAR）的文件时也能正确触发逻辑。
| if (!ZlibUtils.IS_ZLIB_COMPATIBLE && FileUtils.getExtension(artifact).equals("jar")) { | |
| if (!ZlibUtils.IS_ZLIB_COMPATIBLE && "jar".equalsIgnoreCase(FileUtils.getExtension(artifact))) { |
|
Glavo你真是活跃。 |
3 participants
No description provided.