Skip to content

设备代码流在完成授权后隐藏二维码#6087

Open
CiiLu wants to merge 2 commits into
HMCL-dev:mainfrom
CiiLu:mmsssssss
Open

设备代码流在完成授权后隐藏二维码#6087
CiiLu wants to merge 2 commits into
HMCL-dev:mainfrom
CiiLu:mmsssssss

Conversation

@CiiLu
Copy link
Copy Markdown
Contributor

@CiiLu CiiLu commented May 13, 2026

No description provided.

# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
#

Copy link
Copy Markdown
Contributor

@3gf8jv4dv 3gf8jv4dv May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

又被格式化了么 🤔

account.methods.microsoft.hint=点击“登录”按钮开始添加微软账户。
account.methods.microsoft.methods.device=扫描二维码登录
account.methods.microsoft.methods.device.hint=扫描二维码或访问 <a href="%s">%s</a>,在打开的页面中输入 <b>%s</b> 完成登录。
account.methods.microsoft.methods.device.hint.completed=已完成微软账户授权。其余登录步骤将由启动器自动执行,请稍等。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account.methods.microsoft.methods.device.hint.completed=已完成微软账户授权。其余登录步骤将由启动器自动执行,请稍等
account.methods.microsoft.methods.device.hint.completed=已完成微软账户授权。其余登录步骤将由启动器自动执行,请稍候

account.methods.microsoft.hint=點擊「登入」按鈕開始新增 Microsoft 帳戶。
account.methods.microsoft.methods.device=掃描 QR Code 登入
account.methods.microsoft.methods.device.hint=掃描 QR Code 或訪問 <a href="%s">%s</a>,在開啟的頁面中輸入 <b>%s</b> 完成登入。
account.methods.microsoft.methods.device.hint.completed=已完成微软帳戶授權。其余登入步驟將由啟動器自動執行,请稍等。
Copy link
Copy Markdown
Contributor

@3gf8jv4dv 3gf8jv4dv May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account.methods.microsoft.methods.device.hint.completed=已完成微软帳戶授權。其余登入步驟將由啟動器自動執行,请稍等
account.methods.microsoft.methods.device.hint.completed=已完成 Microsoft 帳戶授權。其餘登入步驟將由啟動器自動執行,請稍候

@Glavo
Copy link
Copy Markdown
Member

Glavo commented May 13, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the Microsoft device login flow by introducing a new 'DeviceLoginCompleted' state and event. This ensures that users are notified once the authorization step is finished while the launcher completes the remaining login tasks. The changes involve updates to the OAuth callback interface, the addition of a specific event class, and UI logic to display a completion hint. Review feedback correctly identified a grammatical error in the English localization and character inconsistencies in the Traditional Chinese translation, both of which included specific code suggestions for correction.

account.methods.microsoft.hint=Click the "Log in" button to start adding your Microsoft account.
account.methods.microsoft.methods.device=Log In with QR Code
account.methods.microsoft.methods.device.hint=Scan QR code or visit <a href="%s">%s</a> to complete login, enter <b>%s</b> in the opened page.
account.methods.microsoft.methods.device.hint.completed=Microsoft account authorization is now completed. There are some extra works for us, just wait for a while.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

英文翻译中的 "extra works" 存在语法错误("work" 在此处作为不可数名词)。建议使用更地道的表达方式。

account.methods.microsoft.methods.device.hint.completed=Microsoft account authorization is now complete. We are finishing the login process, please wait a moment.

account.methods.microsoft.hint=點擊「登入」按鈕開始新增 Microsoft 帳戶。
account.methods.microsoft.methods.device=掃描 QR Code 登入
account.methods.microsoft.methods.device.hint=掃描 QR Code 或訪問 <a href="%s">%s</a>,在開啟的頁面中輸入 <b>%s</b> 完成登入。
account.methods.microsoft.methods.device.hint.completed=已完成微软帳戶授權。其余登入步驟將由啟動器自動執行,请稍等。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

繁体中文资源文件 (I18N_zh.properties) 中混入了简体中文汉字(“微软”、“其余”、“请”)。为了保持一致性,建议将其转换为繁体中文,并参考同文件其他条目(如第 122 行)将“微软”统一为 “Microsoft”。

account.methods.microsoft.methods.device.hint.completed=已完成 Microsoft 帳戶授權。其餘登入步驟將由啟動器自動執行,請稍等。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants