Skip to content

Deprecate pickle saving in PolicyApproximator #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZachParent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate pickle saving in PolicyApproximator #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/pgeon/policy_approximator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,19 +596,15 @@ def save(self, format: str, path: Union[str, List[str]]):
"""
Save the policy approximator

:param format: The format to save in (e.g., 'json', 'pickle')
:param format: The format to save in (e.g., 'csv')
:param path: The path to save to
"""
if not self._is_fit:
raise Exception("Policy approximator cannot be saved before fitting!")

# Implement appropriate save functionality based on the format
if format == "json":
# Implement JSON serialization
pass
elif format == "pickle":
# Implement pickle serialization
pass
if format == "csv":
raise NotImplementedError("CSV format has not been implemented yet")
else:
raise NotImplementedError(f"Format {format} not supported for saving")

Expand Down