Update reproducing.m, PTR-BCR-4 #54

tiresias7 · 2022-04-03T04:14:08Z

Update the PTR-BCR-4 part, Eq. 68

tiresias7 · 2022-04-03T04:26:40Z

More details on discord!

ndattani · 2022-04-07T01:02:53Z

Thank you so much @tiresias7! Preferably all communications about this Pull Request can remain here in this thread, rather than in private messages in Discord, because it will be much easier to find things that way.

I would also encourage you to do the following:

Test the equation in the "Summary" section for k = 8.
Test the equation in the "Alternate forms" section for k=8.
Expand the equation in the "Example" section and add it in a new line (with an equation number too). You can add this into the book's source code here.
Once you're done the above step, then add "LaTeX" to your resume :) Please don't send me a new copy of the resume though.
The expanded version of the "Example" should also be tested in reproducing.m.
Once the added equation is in the book's PDF file, please show a screenshot of just that equation (not the full page) in a reply here, so that I can verify that the PDF looks good :)

If you need help compiling the book's source code, you can ask Eric Huang (ehuan2) in this thread.

ndattani · 2022-04-07T01:18:14Z

@ehuan2 Can you write some advice here about how you compiled the book's source code locally into a PDF with only +10 changes?

ehuan2 · 2022-04-07T18:20:34Z

@ehuan2 Can you write some advice here about how you compiled the book's source code locally into a PDF with only +10 changes?

Yeah so the issue that was creating a lot of changes that we don't need necessarily was the fact that my compiler created log files that looked very different because of different versions, different file systems, etc. So I just kind of ignored those changes when adding to the commit. Another thing is what you're using, I have TeXWorks installed on Windows, and that allows you to compile with lots of different stuff, which some didn't work until I compiled with just pdfLatex.

Another option is just to compile online using something like overleaf, and copying it back locally.

tiresias7 · 2022-04-12T03:35:39Z

Hi @ndattani ! Today I finished one of my final exams and decided to complete the steps.

However, I'm a little bit stuck. In PTR-BCR-4, it requires k=2^(m+1). Maybe k=6 won't work for this?

Also, I'm wondering if I'm doing the right thing with Github. I first merged the current version of the whole branch to my fork, and then pushed the commits in this pull request to the patch-1 branch (I guess?). Am I doing the right thing?

ndattani · 2022-04-12T13:00:47Z

Hi @tiresias7, can you try `k=8`? As for your second question, it was correct to merge the current version from HPQC-LABS/Master to tiresias7/Master (though you seemed to merge it into tiersias7:patch-1 which is also okay). The pull request should now automatically have the latest commits from HPQC-LABS/Master and from your initial commits to patch-1. You can continue to make commits to patch-1. Let me know if you have any questions!

Added Eq.71 and 73 with k=8, checked correctness

Added an equation, also fixed some typo

Added equation 73

tiresias7 · 2022-04-13T06:29:37Z

Hi @ndattani ! I think I've done all the things. k=8 is really big, so I used the for-clause to avoid listing out all the products of b1,2,...,11.

I have changed the tex file. Hope it's good. I also fixed some typos on the same page - I couldn't believe it when I found that the original formula on the book has actually a typo. How did I make it last time?

Here is the formula:

Since I have done some other changes, I decided to post the whole page of pdf here.

Thank you so much for your help!
P.S. The formulas are really messy and the sum notations are unclear. I had a hard time struggling to find that the two sum notations start at different integers (1 and 0).

ndattani · 2022-04-19T22:53:35Z

everything_else/reproducing.m

@@ -157,6 +157,81 @@
 %% Pg. 21, PTR-BCR-2
 %% Pg. 22, PTR-BCR-3 (example appears to be the same as PTR-BCR-1, and may have to be redone)
 %% Pg. 23, PTR-BCR-4 
+
+% Eq. 72


Equation numbers can change, when new questions get added or old ones get removed. Instead of calling something "Eq. 72" it's better to give a description, such as "Equation in Summary section of PTR-BCR-4". Earlier we were using equation numbers in this file, but now things are changing and we're moving away from using equation numbers in that way (and we're moving more towards using descriptions).

ndattani · 2022-04-20T02:31:58Z

everything_else/reproducing.m

@@ -157,6 +157,81 @@
 %% Pg. 21, PTR-BCR-2
 %% Pg. 22, PTR-BCR-3 (example appears to be the same as PTR-BCR-1, and may have to be redone)
 %% Pg. 23, PTR-BCR-4 
+


Eq. 71 should come before Eq. 72.

ndattani · 2022-04-20T02:36:38Z

everything_else/reproducing.m

+LHS = min(reshape(b1.*b2.*b3.*b4, 4, []));
+RHS = min(reshape((b1 + b2 + b3 + b4 - ba1 - 2*ba2).^2, 4, []));
+isequal(LHS,RHS); % Gives 1, confirmed by Nike on 6 April.
+


While I appreciate that it would take a long time to type out b1*b2 + b1*b3 + b1*b4 + ... for all terms, I think that it would be more "readable". For all other quadratizations verified in this file so far, it's easy to compare the equation in the book with the code and immediately see that they're the same. In this case, it's a lot more complicated. Perhaps you can use MATLAB's symbolic computing toolbox to help.

I think I'd prefer MATLAB code that looks as close as possible to the equations in the book, then we can also keep your code containing the for loops (so we have two different verifications for each equation: one "long" one that's easy to read, and one "compact" one which requires the reader to interpret a bunch of for and end statements).

ndattani · 2022-04-20T02:49:29Z

This is very good work all around @tiresias7 !

"P.S. The formulas are really messy and the sum notations are unclear. I had a hard time struggling to find that the two sum notations start at different integers (1 and 0)."

I'm very impressed that you found those typos! Have you looked at "Remark 5" from the paper in the Bibliography section? That should make it clear where the indices should start and end.
By changing the starting indices to be from 0 instead of 1, the first equation in the "Example" section would have to change too. Can you make it so that all indices start at 1 (i.e. adjust the exponents accordingly)? This way the general equation in the Summary section doesn't need indices (it should be consistent that all indices start at 1 and go as high as possible, unless an upper index is explicitly stated).
For the first equation of the Example section, the a_1 and a_2 should have 1 and 2 as subscripts
The citation in the Bibliography section is showing up as a question mark. Are you able to get that fixed by compiling this way?
Please also push your .pdf file to your fork :)

ndattani · 2022-08-18T05:08:57Z

@tiresias7
I'll be publishing the next version of the book soon.
If you want your name mentioned here: https://arxiv.org/abs/1901.04405 and here: https://github.com/HPQC-LABS/Book_About_Quadratization you would only need to fix the above issues so that this branch can be merged into the Master branch.

tiresias7 · 2022-08-24T00:11:13Z

@ndattani I'm so sorry that I've left this task undone. Is it still possible for me to finish this now?

ndattani · 2022-08-24T12:56:17Z

@tiresias7 yes for sure!

tiresias7 · 2022-08-26T01:30:10Z

It has been a long way before I pick this up so it's a little hard for me to catch up. I've changed the comments for equations to be clearer and more direct. I also changed one of the formulas to become a more the readable and easy-to-check form (however very long) and check that LHS = RHS. If I'm going to do the same thing to the other formula, it would be 4 times longer than this current line, which is already 300 characters long. Should I do it or it is too long an example?

tiresias7 · 2022-08-26T01:32:11Z

Besides this, do I also have to change the pdf file?

By changing the starting indices to be from 0 instead of 1, the first equation in the "Example" section would have to change too. Can you make it so that all indices start at 1 (i.e. adjust the exponents accordingly)? This way the general equation in the Summary section doesn't need indices (it should be consistent that all indices start at 1 and go as high as possible, unless an upper index is explicitly stated).

In my understanding, I'm going to change indices to 1. Is that right?

Update reproducing.m

1ae6292

Update the PTR-BCR-4 part, Eq. 68

ndattani added 2 commits April 6, 2022 16:31

Added "isequal" command at end of BCR-4 in reproducing.m

a9538c7

Simplified RHS of PTR-BCR-4

78a0ca3

Merge branch 'HPQC-LABS:master' into patch-1

0ad8393

tiresias7 added 3 commits April 13, 2022 02:03

Update reproducing.m

e1a2c70

Added Eq.71 and 73 with k=8, checked correctness

Update Book_about_Quadratization.tex

d70ad3a

Added an equation, also fixed some typo

Update reproducing.m

588e9d7

Added equation 73

This was referenced Apr 19, 2022

Proving PTR-BCR-4 #55

Closed

Changes for PTR-BCR-2 #56

Open

ndattani reviewed Apr 19, 2022

View reviewed changes

ndattani reviewed Apr 20, 2022

View reviewed changes

ndattani mentioned this pull request Apr 23, 2022

Added verification for PTC-BCR-3 #58

Closed

Clarify Equation names; Change for to exploded

4067e14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update reproducing.m, PTR-BCR-4 #54

Update reproducing.m, PTR-BCR-4 #54

tiresias7 commented Apr 3, 2022

tiresias7 commented Apr 3, 2022

ndattani commented Apr 7, 2022 •

edited

Loading

ndattani commented Apr 7, 2022

ehuan2 commented Apr 7, 2022

tiresias7 commented Apr 12, 2022

ndattani commented Apr 12, 2022 via email •

edited

Loading

tiresias7 commented Apr 13, 2022

ndattani Apr 19, 2022

ndattani Apr 20, 2022

ndattani Apr 20, 2022 •

edited

Loading

ndattani commented Apr 20, 2022

ndattani commented Aug 18, 2022

tiresias7 commented Aug 24, 2022

ndattani commented Aug 24, 2022

tiresias7 commented Aug 26, 2022

tiresias7 commented Aug 26, 2022

Update reproducing.m, PTR-BCR-4 #54

Are you sure you want to change the base?

Update reproducing.m, PTR-BCR-4 #54

Conversation

tiresias7 commented Apr 3, 2022

tiresias7 commented Apr 3, 2022

ndattani commented Apr 7, 2022 • edited Loading

ndattani commented Apr 7, 2022

ehuan2 commented Apr 7, 2022

tiresias7 commented Apr 12, 2022

ndattani commented Apr 12, 2022 via email • edited Loading

tiresias7 commented Apr 13, 2022

ndattani Apr 19, 2022

Choose a reason for hiding this comment

ndattani Apr 20, 2022

Choose a reason for hiding this comment

ndattani Apr 20, 2022 • edited Loading

Choose a reason for hiding this comment

ndattani commented Apr 20, 2022

ndattani commented Aug 18, 2022

tiresias7 commented Aug 24, 2022

ndattani commented Aug 24, 2022

tiresias7 commented Aug 26, 2022

tiresias7 commented Aug 26, 2022

ndattani commented Apr 7, 2022 •

edited

Loading

ndattani commented Apr 12, 2022 via email •

edited

Loading

ndattani Apr 20, 2022 •

edited

Loading