Skip to content

Enable car ferries for Kela configuration #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Antiik91 wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Enable car ferries for Kela configuration #5604

Antiik91 wants to merge 1 commit into from
+9 −3

Conversation

@Antiik91
Copy link
Member

@Antiik91 Antiik91 commented Dec 19, 2025 •
edited
Loading

Proposed Changes

  • Add car ferries to kela configuration.
  • Calculate the whole journey when emphasizeOneWayJourney is enabled

Note on testing

  • It is asked by the stakeholders to verify that these changes does not enable routing to Sweden or Estonia.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

vesameskanen
vesameskanen requested changes Dec 19, 2025
View reviewed changes
app/util/legUtils.js
export function getTotalDrivingDistance(itinerary) {
export function getTotalDrivingDistance(itinerary, config = {}) {
// Don't rely only driving legs when calculating the one way journey.
if (config?.emphasizeOneWayJourney) {
Copy link
Member

@vesameskanen vesameskanen Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for ? as you provide default for config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vesameskanen vesameskanen vesameskanen requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Antiik91 @vesameskanen