AB#74 refactore near you view thoroughly #5607
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to prefix everything with 'Stop'
Pass consistent currentTime and tab activation props to child components.
- Remove fake props - reqeuire all props
- Convert to function component - Rename and simplify - Remove useless state, use refs not state - Simple aria messages
- expose only props which are accessed - rename - use Memo
- expose only props which are accessed - rename - use Memo
This has apparently been always broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several bugs got fixed, for example favorites near you now shows vehicles on map.