Merged
Conversation
tunetheweb
requested changes
May 6, 2025
Member
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Look pretty good, but suggested some clean ups and things to make it more generic.
Contributor
Author
|
Thank you for descriptive feedbacks, I've addressed them and made the following changes:
|
tunetheweb
approved these changes
May 6, 2025
Member
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Did some minor tweaks in f11cb0c but this LGTM to me now.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a "Call for Contributors" announcement for all languages.
If the default year is the current year, this call-to-action will be displayed.