Skip to content

Update PDF URLs to use the new path#4293

Merged
max-ostapenko merged 1 commit intomainfrom
objective-tapir
Dec 17, 2025
Merged

Update PDF URLs to use the new path#4293
max-ostapenko merged 1 commit intomainfrom
objective-tapir

Conversation

@max-ostapenko
Copy link
Copy Markdown
Contributor

@max-ostapenko max-ostapenko commented Dec 17, 2025

The path has changed after replacing a direct GCS bucket backend with a proxy.

It's strange that the false paths in the tests didn't highlight it in earlier PRs.

Copy link
Copy Markdown
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch! I’ll also need access to the bucket to be able to upload new PDFs to it.

@max-ostapenko
Copy link
Copy Markdown
Contributor Author

max-ostapenko commented Dec 17, 2025

Write was restricted even before.
So your access should be fine.

@max-ostapenko max-ostapenko merged commit 4d62071 into main Dec 17, 2025
12 checks passed
@max-ostapenko max-ostapenko deleted the objective-tapir branch December 17, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants