-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote functions #67
base: main
Are you sure you want to change the base?
remote functions #67
Conversation
max-ostapenko
commented
Feb 24, 2025
•
edited
Loading
edited
- rewritten export trigger function
- async Firestore export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR rewrites the export trigger function and implements an asynchronous Firestore export mechanism while also updating related documentation and Dataform definitions.
- Rewritten export trigger function and updated Firestore batch processing logic
- Adjusted Cloud Run function path reference in the README
- Updated Dataform report definitions to invoke export jobs with new JSON payloads
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
infra/bigquery_export_spark/src/firestore.py | Implements Firestore batching operations for document export |
README.md | Updates workflow triggering path and repository structure documentation |
infra/bigquery-export/index.js | Refactors export logic to switch between Cloud Storage and Firestore exports |
definitions/output/reports/* | Updates report definitions with new export job configurations and JSON payloads |
includes/constants.js | Retrieves environment variable from project configuration |
console.log(exportConfig) | ||
const techReports = new TechReportsExporter() | ||
await techReports.export(exportConfig) | ||
const firestore = new FirestoreBatch() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FirestoreBatch is defined to require a configuration argument in its constructor, yet it is instantiated without one here. Consider passing 'config' to the constructor (e.g., new FirestoreBatch(config)) and adjust the export() method accordingly.
const firestore = new FirestoreBatch() | |
const firestore = new FirestoreBatch(config) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Co-authored-by: Copilot <[email protected]>