Skip to content

Field color labeling and decision tree - #1704

Merged
schmidma merged 39 commits into
HULKs:mainfrom
Franziska-Sophie:field-color-detection
Jul 15, 2025
Merged

Field color labeling and decision tree#1704
schmidma merged 39 commits into
HULKs:mainfrom
Franziska-Sophie:field-color-detection

Conversation

@Franziska-Sophie

@Franziska-Sophie Franziska-Sophie commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why? What?

New pipeline for automatic field color calibration:

  • Start the python script
  • Select the images you want to label
  • Label one image after another with the build-in labeling tool (the label masks will be cached in case you want to use them again)
  • After the last image was labeled, the decision trees (one for top and bottom camera) is trained
  • The tree is converted to if-else statements in rust where the code is printed to the console and stored in a .rs file

How to Test

  • Run the script to get the decision tree
  • Use twix to check whether the image segmentation looks good

@github-project-automation github-project-automation Bot moved this to Request for Review in Development Mar 13, 2025
oleflb
oleflb requested changes Mar 13, 2025
View reviewed changes

@oleflb oleflb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add types to all of your functions :)

Comment thread tools/field_color_detection/.gitignore Outdated
Comment thread tools/field_color_detection/src/decision_tree/__init__.py Outdated
Comment thread tools/field_color_detection/src/decision_tree/generate_tree.py Outdated
Comment thread tools/field_color_detection/src/decision_tree/generate_tree.py Outdated
Comment thread tools/field_color_detection/src/decision_tree/generate_tree.py Outdated
Comment thread tools/field_color_detection/src/decision_tree/generate_tree.py Outdated
Comment thread tools/field_color_detection/train_field_color_thresholds.py Outdated
@oleflb oleflb self-assigned this Mar 13, 2025
@schmidma
schmidma force-pushed the field-color-detection branch from 5689559 to 9c36821 Compare March 14, 2025 14:05
@schmidma
schmidma force-pushed the field-color-detection branch from 81ac11c to 491fa67 Compare July 14, 2025 12:02
@schmidma
schmidma force-pushed the field-color-detection branch from 13d4b1c to a3a4a60 Compare July 14, 2025 15:38
oleflb
oleflb requested changes Jul 14, 2025
View reviewed changes

@oleflb oleflb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add joblib file to git lfs
  • I cannot test it right now due to paramalarm

@schmidma
schmidma force-pushed the field-color-detection branch 2 times, most recently from 93cc03d to 3a97824 Compare July 14, 2025 17:07
@schmidma
schmidma enabled auto-merge July 14, 2025 17:28
@schmidma
schmidma force-pushed the field-color-detection branch from 6618fa1 to f2ed51b Compare July 15, 2025 12:41
oleflb
oleflb requested changes Jul 15, 2025
View reviewed changes
Comment thread crates/vision/src/image_segmenter.rs Outdated
Comment thread crates/vision/src/image_segmenter.rs Outdated
Comment thread crates/vision/src/image_segmenter.rs Outdated
Comment thread crates/vision/src/image_segmenter.rs
Comment thread crates/vision/src/image_segmenter.rs
oleflb
oleflb previously approved these changes Jul 15, 2025
View reviewed changes
@schmidma
schmidma added this pull request to the merge queue Jul 15, 2025
Merged via the queue into HULKs:main with commit 2691e20 Jul 15, 2025
27 checks passed
@schmidma
schmidma deleted the field-color-detection branch July 15, 2025 16:13
@github-project-automation github-project-automation Bot moved this from Request for Review to Done in Development Jul 15, 2025
@paudar paudar mentioned this pull request Jan 20, 2026
Closed
rmburg added a commit to rmburg/hulk that referenced this pull request Mar 11, 2026
@rmburg
Revert "Field color labeling and decision tree (HULKs#1704)"
2f69953 
This reverts commit 2691e20.
github-merge-queue Bot pushed a commit that referenced this pull request Mar 11, 2026
@rmburg
Revert field color decision tree (#2322)
38d015a 
* Revert "Field color labeling and decision tree (#1704)"

This reverts commit 2691e20.

* bump twix version

* tune vision parameters

* fix twix vision panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleflb oleflb oleflb approved these changes

Assignees

@oleflb oleflb

Labels

cat:Calibration cat:Vision

Projects

Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Franziska-Sophie @oleflb @schmidma