Standup refactor - #1904
Merged
Merged
Conversation
schluis
enabled auto-merge
July 4, 2025 13:51
schluis
disabled auto-merge
July 4, 2025 14:03
schluis
enabled auto-merge
July 4, 2025 14:34
knoellle
requested changes
Jul 5, 2025
knoellle
left a comment
knoellle
left a comment
Member
There was a problem hiding this comment.
Good cleanup, thanks!
I do have some comments though, mostly related to storing data in the MotionType and remaining duration estimation.
knoellle
reviewed
Jul 7, 2025
github-project-automation
Bot
moved this from Request for Review
to Done
in Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
Build on #1900 and reduces code duplication
How to Test
Let it stand up multiple times and see if the motion slows down