deny standup after 3 tries and ouch - #1905
Merged
Merged
Conversation
knoellle
previously requested changes
Jul 5, 2025
schluis
reviewed
Jul 9, 2025
schluis
requested changes
Jul 9, 2025
schluis
approved these changes
Jul 13, 2025
github-project-automation
Bot
moved this from Request for Review
to Done
in Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
Make ouch sound and change motion command when starting 3rd stand up attempted (parameter debatable). This should be to avoid standing up too often in the competition when the robot is broken and the referee does not see it.
Fixes #1756
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Let robot (gently) stand up 3 or more times in a row and observe an unstiff robot and a single ouch sound. Making the robot stable again (Penalized, Walking, Stand, Initial) brings it back to normal function.