Replace Arc<Vec<YCbCr422>> with Arc<[YCbCr422]> - #1912
Closed
oleflb wants to merge 1 commit into
Closed
Conversation
oleflb
changed the title
Arc<Vec<YCbCr422>> with Arc<[YCbCr422]>
oleflb
enabled auto-merge
July 10, 2025 15:41
schmidma
reviewed
Jul 10, 2025
| width_422, | ||
| height, | ||
| buffer: Arc::new(data), | ||
| buffer: Arc::from(data), |
Member
There was a problem hiding this comment.
How does this behave with respect to copying? Is this just taking ownership and moving the pointers behind Vec?
Contributor
Author
There was a problem hiding this comment.
Yes, this takes ownership. It's the same as Box<[u8; N]> but with an Arc
Member
|
This does not work, as this |
auto-merge was automatically disabled
July 15, 2025 12:28
Pull request was closed
github-project-automation
Bot
moved this from Request for Review
to Done
in Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
YCbCr422image had an unnecessary double indirection.Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test