Go back to official pyo3-log - #2172
Merged
Merged
Conversation
knoellle
requested changes
Jan 9, 2026
knoellle
left a comment
knoellle
left a comment
Member
There was a problem hiding this comment.
Wanted to test this, but my mujoco-rust-server didn't rebuild when switching between your commit and the one its based on.
Please add the top level Cargo.toml/lock to the cache relevant paths in tools/mujoco-simulator/mujoco-rust-server/pyproject.toml.
Member
|
Worked fine when manually rebuilding though |
Contributor
Author
Done |
Member
|
Taplo still isn't happy with your 2525ad1 😅 |
oleflb
force-pushed
the
remove-pyo3-fork
branch
from
January 15, 2026 20:18
2525ad1 to
d95d652
Compare
github-project-automation
Bot
moved this from Request for Review
to Done
in Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
pyo3-logupdated topyo30.27, so we don't have to use my fork anymore.Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Describe how to test your changes. (For the reviewer)