Bump egui + bevy versions - #2820
Open
oleflb wants to merge 3 commits into
Open
Conversation
knoellle
requested changes
Jul 24, 2026
knoellle
left a comment
knoellle
left a comment
Member
There was a problem hiding this comment.
Minor comment, LGTM otherwise
Comment on lines
10
to
13
| ctx.on_begin_pass("keybinds", Arc::new(|ui| begin_frame(ui.ctx()))) | ||
| } | ||
|
|
||
| fn begin_frame(ctx: &Context) { |
Member
There was a problem hiding this comment.
This function isn't used anywhere else. Why not change its signature instead of wrapping it in a closure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
Bumps bevy to 0.19.0 and egui to 0.35.0. This also requires to increase MSRV to
1.95.0Motivation is the new simulator, which will need features from bevy 0.19
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test