Responsive equipGear modal and popover - fixes #10048#15621
Open
michaelpipkin wants to merge 3 commits into
Open
Responsive equipGear modal and popover - fixes #10048#15621michaelpipkin wants to merge 3 commits into
michaelpipkin wants to merge 3 commits into
Conversation
Author
|
I'm a first time contributor so the workflow for tests hasn't run automatically. Please can an admin click the button to start it? |
Author
SabreCat
force-pushed
the
develop
branch
2 times, most recently
from
April 8, 2026 20:36
2d54f93 to
d465efa
Compare
Author
|
@SabreCat is there anything else I need to do to move this along? Or is it just in the pipeline, waiting for a review and approval? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #10048
Changes
When using non-English languages, the equipment stat grid (STR/INT/CON/PER) in both the equip gear modal and the equipment popover could cause translated text to wrap mid-word or overflow its container. This happened because the layout relied on fixed widths and percentage-based sizing that did not accommodate longer translated strings.
The root cause was a circular width expansion chain: .inner-content used width: max-content, which caused it to expand to the size of its children. Those children (.popover-content-attr) used calc(50% - 1px) percentages, which calculated against the inflated parent — creating a feedback loop. Additionally, the flex-wrap layout on .attributes-group had no stable column-width reference, so stat boxes could end up different sizes or wrap unexpectedly.
UUID: 894f5a0d-d3f7-4f45-a0f9-29bf86e6d461