-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/session wide algorithm #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 28 commits
28714c6
d2588ee
974f949
356ae5a
3e6ab9b
7b4b6ea
d2ca704
8872031
04b2007
705b8d7
da2baeb
fa4ff29
573adef
8862067
16fb835
ff504c9
54b156d
8e4c621
cd05c4a
45888ce
efe2242
3ddbf98
445ab62
6a642b3
e451a8c
628c4f4
54b7d67
ba22470
c20df47
e0c47ee
5fb1b9f
32560d5
1028ff4
4d6adc6
6e89704
c60587a
15b2745
4de56f0
e16c74c
8878335
dac6a7e
c499a7b
5c6357a
8f4b407
55c8325
320051d
ae15a0a
475e66f
770f144
714dc44
7a0067c
81d995f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,7 @@ rules_version = '2'; | |||||
| service firebase.storage { | ||||||
| match /b/{bucket}/o { | ||||||
| match /{allPaths=**} { | ||||||
| allow read, write: if true; | ||||||
| allow read, write: if false; | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainCritical: Verify that denying all storage access is intentional. This change denies all read/write access to Firebase Storage, which will break any storage-dependent functionality in the application. This seems unrelated to the scheduling algorithm work described in the PR objectives. If this is a temporary development/testing change, it should not be committed to the main branch. If intentional, please clarify the reasoning. Consider reverting this change unless there's a specific reason to deny all storage access: - allow read, write: if false;
+ allow read, write: if true;Or implement proper access control rules based on your security requirements instead of blanket denial. I'll gather the necessary information to verify this review comment. Let me inspect the storage rules file and the context around this change. 🏁 Script executed: #!/bin/bash
# Examine the storage.rules file to understand the full context
echo "=== Full storage.rules file ==="
cat storage.rules
echo -e "\n=== Git diff for storage.rules ==="
git diff storage.rules
echo -e "\n=== Git log for storage.rules (last 5 commits) ==="
git log --oneline -5 -- storage.rules
echo -e "\n=== Checking for any related documentation or comments ==="
rg -n "storage" --type-list | head -20Length of output: 1056 🏁 Script executed: #!/bin/bash
# Search for any references to storage rules or access control in the codebase
echo "=== References to Firebase Storage or access control ==="
rg -i "storage" -B2 -A2 --type=md --type=json --type=ts --type=js -g '!node_modules' | head -50Length of output: 1891 Let me search for actual Firebase Storage usage in the codebase to understand if this rule change would genuinely break functionality. 🏁 Script executed: #!/bin/bash
# Search for Firebase Storage method calls and operations
echo "=== Firebase Storage operations in application code ==="
rg -i "uploadBytes|download|getBytes|put|get\(|ref\(" -B2 -A2 --type=ts --type=js -g '!node_modules' | head -80
echo -e "\n=== Direct storage references ==="
rg "firebase\.storage|getStorage|ref\(|uploadFile|readFile" -B1 -A1 --type=ts --type=js -g '!node_modules'
echo -e "\n=== Check PR or commit context ==="
git show --stat 445ab62 | head -30Length of output: 7799 🏁 Script executed: #!/bin/bash
# Look for README or documentation about this change
echo "=== Checking README or docs ==="
find . -maxdepth 2 -name "README*" -o -name "CHANGELOG*" -o -name "*.md" | head -10 | xargs grep -l "storage" 2>/dev/null || echo "No matches found in docs"
echo -e "\n=== Checking for TODOs or FIXMEs related to storage ==="
rg "TODO|FIXME" -i --type=ts --type=js --type=rules -B1 -A1 -g '!node_modules' | grep -i storage -B2 -A2Length of output: 130 Critical: Storage rules deny all access while application code actively uploads and downloads files. Evidence shows the application uses Firebase Storage operations:
The current rule - allow read, write: if false;
+ allow read, write: if request.auth != null;Or use authentication-based rules as suggested by the commented code in the file referencing admin checks. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
| } | ||||||
| } | ||||||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.