React1 week2/gayathri #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the week1 homework |
Comment on lines
+12
to
+17
| const onAddOrRemovePlanet = (name, index) => { | ||
| setSelectedPlanets((prevSelected) => { | ||
| if (prevSelected.includes(name)) { | ||
| return prevSelected.filter((planet) => planet !== name); | ||
| } else { | ||
| return [...prevSelected, { name }]; |
There was a problem hiding this comment.
Careful, there's a bug here 🐛
You should return
return [...prevSelected, name]Right now you are appending an object containing name instead of just adding the name string, therefore you are not entering the if case.
This causes problems because:
The includes() is looking for a string but comparing against objects
The isSelected prop in PlanetCard is using includes() which won't work with objects
If you run the app and keep selecting the same planet you are just appending more and more objects to that array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.