Nodejs week3/aminata #243
Open
Nodejs week3/aminata #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2025 02:36
LucasIversen
approved these changes
Apr 9, 2025
Collaborator
LucasIversen
left a comment
LucasIversen
left a comment
There was a problem hiding this comment.
Hi Aminata. There's a couple of things you could fix here, but you should only do it if you feel it's worth while since it's been so long since this was due :)
| let query= knexInstance.select("*").from("contacts"); | ||
|
|
||
| if ("sort" in req.query){ | ||
| const order = req.query.sort.toString; |
|
|
||
| console.log("SQL", query.toSQL().sql); | ||
|
|
||
| try { |
Collaborator
There was a problem hiding this comment.
This is placed outside the handler. It needs to be inside the contactsAPIRouter.get('/',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.