Itp2026 1/benjamin vanderzeypen - #1
Open
nuttyproducer wants to merge 15 commits into
Open
Conversation
I prepared my form to what input styles i will need. and what Headings to use H1 and H2.
Adding both tags where needed for accessibility reasons.
Implemented the radio buttons for Porridge and Beds
Dropdown menus for favorite bear and preferred greeting
I've added those two sections in the form. Remove h1 and h2 comments in html Refactor other comments in html
I made some typos, restructured and fix typos, added the image, delete .form-section (not used) Learned again too place the image correctly in CSS
Updating paragraph color
I saw the stretch at the end when i was about to create a PR. I also forgot to add the "links" in the first paragraph.
In HTML5, you don’t need a / at the end of self-closing tags (like <meta />, <br />, <input />).
and improve button type for submission according to WAVE 10/10 result.
While reviewing others code, I checked my code again and added some fixes and improvements. Document checking completed. No errors or warnings to show.
Author
|
Hello @talmurshidi , I did some reviews on others people code and that's why I went back to review my code again and I still found some flaws. I've corrected a lot of them but I also had my code reviewed this time by AI to see where I was missing out. It actually showed almost zero mistakes so I'm quiet happy with this result myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tasks of the README.md file are accomplished.
Lighthouse score for accessibility = 100%
Tasks:
Questions:
I see that there's are no Required options in the assignment. But in my opinion it's always best to add a small note that fields with an * are required. I've learned this with using AIRA labels. I haven't included it in this code, but is this in general a good practice to you?