Conversation
|
since we're basically building this to fit our needs, could you include in the PR an example of how it's used and it working successfully? it's a little hard for me to visualize otherwise. |
hhoopes
approved these changes
Feb 27, 2025
hhoopes
left a comment
hhoopes
left a comment
There was a problem hiding this comment.
Seeing a use case of how this is working in our specs might be nice, but no reason not to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up needing to create a new mocked object to match with stripes implementation. This change mocks the payment method object and fills in the card details so that the hash can be accessed by our serializer. We needed the full payment method object to be returned to have the object in our serializer.
To test:
This Branch was tested against our own external test suite and passed.