Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG sponsor assets with SVGs #70

Open
MattIPv4 opened this issue Sep 24, 2024 · 10 comments · May be fixed by #75
Open

Replace PNG sponsor assets with SVGs #70

MattIPv4 opened this issue Sep 24, 2024 · 10 comments · May be fixed by #75
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MattIPv4
Copy link
Member

Feature Suggestion

Feature description

Replace all the PNGs found in https://github.com/Hacktoberfest/hacktoberfest-2022/tree/main/src/assets/img/partners with SVG equivalents.

How the feature is useful

Better fidelity of the assets.

@MattIPv4 MattIPv4 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 24, 2024
@Siddharthgup
Copy link

Hi @MattIPv4 ,Can you assigned this task to me ?

@MattIPv4
Copy link
Member Author

Sure 👍

@Anandprafull Anandprafull linked a pull request Oct 1, 2024 that will close this issue
@Anandprafull
Copy link

Anandprafull commented Oct 1, 2024

@MattIPv4 Please check the PR i have replaced the assets as well as the related sponser.js code

@MattIPv4
Copy link
Member Author

MattIPv4 commented Oct 1, 2024

@Anandprafull this issue was already assigned to someone else to work on...

@Anandprafull
Copy link

I see but since there hadn't been any update on the issue so i worked on it..

@MattIPv4
Copy link
Member Author

MattIPv4 commented Oct 1, 2024

Yup, but it has only been three days since they asked for it to be assigned to them, and only a day since Hacktoberfest started. It is important to communicate on issues, especially where they are assigned to someone else, not just assume you can do it instead.

I'll leave your PR up for now, but there are issues with it that need to be addressed.

@MattIPv4
Copy link
Member Author

MattIPv4 commented Oct 3, 2024

@Siddharthgup Are you intending to work on this still?

@Siddharthgup
Copy link

Yes,It's almost completed

@Lokeshsuwalka05
Copy link

Hello,if it's still open.
Can you assign this issue to me??

@MattIPv4
Copy link
Member Author

MattIPv4 commented Oct 5, 2024

@Lokeshsuwalka05 as you can see from the issue itself, it is already assigned to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants