Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG sponsor assets with SVGs #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anandprafull
Copy link

@Anandprafull Anandprafull commented Oct 1, 2024

What should this PR do?

  • Replace PNGs with SVGs: This PR proposes to replace all PNG images found in the src/assets/img/partners directory with their SVG equivalent sand updated along with their code integrations.
    • Reason: SVGs are vector graphics that scale without loss of quality, providing better fidelity for assets displayed on various screen sizes and resolutions. This change enhances the visual appearance and performance of the application.

What issue does this relate to?

Closes #70

What are the acceptance criteria?

  • Reviewers should check the following before approving this PR:
    • All PNG files in the specified directory have been successfully replaced with SVG files.
    • The new SVG images are rendering correctly in the application without any visual discrepancies.
    • The overall file size of the assets has been optimized.
    • Ensure that all tests and linting pass before merging.
    • Verify that there are no broken links or references to the old PNG files in the codebase.

@MattIPv4 MattIPv4 changed the title Replaced PNG sponsor assets with SVGs #70 Replace PNG sponsor assets with SVGs Oct 1, 2024
@MattIPv4
Copy link
Member

MattIPv4 commented Oct 1, 2024

👋 Where did you source these SVGs, many of them seem rather low fidelity?

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 3, 2024

👋 @Anandprafull Any update on this? It somewhat looks like you used an SVG tracer to generate the SVGs here from the PNGs, rather than seeking original SVG assets from the brands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace PNG sponsor assets with SVGs
2 participants