Update of About window + format #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarL
reviewed
Dec 20, 2025
Src/Headers/Constants.h
Outdated
| K_PREFS_WINDOW_QUIT = 'pfwq' | ||
| K_PREFS_VIEW_RESET_COLOR_DEFAULTS = 'pcrd', | ||
| K_PREFS_VIEW_RESET_COMMAND_DEFAULTS = 'pcmd', | ||
| K_PREFS_VIEW_RESET_TOOLBAR_DEFAULTS = 'pvrt', |
Src/Source/AboutWindow.cpp
Outdated
| m_beBits = new BButton( | ||
| btnRect, "fBeBitsbtn", "BeBits Page", new BMessage(AboutMessages::K_GOTO_BETEX_BEBITSPAGE)); | ||
| m_gradient->AddChild(m_beBits); | ||
| /* Long gone .... |
There was a problem hiding this comment.
Just removing the dead code might be better.
There was a problem hiding this comment.
The PR description doesn't mentions why these changes in this file are necessary. The messy commit history makes it hard to see if it was mentioned in a commit message.
Contributor
|
Please use a rebased branch for new commits instead of the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Improvements in AboutWindow : get rid of bebits page, update url for donate/homepage.
-Code formatting