Skip to content

Design liquid glass console surfaces#53

Closed
Hamedghz wants to merge 1 commit into
AIONOSfrom
codex/organize-packaging-and-imports-for-app-mlymmh
Closed

Design liquid glass console surfaces#53
Hamedghz wants to merge 1 commit into
AIONOSfrom
codex/organize-packaging-and-imports-for-app-mlymmh

Conversation

@Hamedghz

@Hamedghz Hamedghz commented Nov 7, 2025

Copy link
Copy Markdown
Owner

Summary

  • add a reusable GlassPanel component, update the global Tailwind theme with Liquid Glass styling, and pull in the Tailwind forms plugin
  • refresh the login, setup, and dashboard app router pages with RTL-friendly Liquid Glass layouts and move onboarding to /setup
  • set the root layout to RTL to match the new kit and clean up the legacy onboarding page

Testing

  • pnpm lint (fails: createTranslator is not a function in next.config.mjs)

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/control/Dockerfile
Comment on lines +11 to +22
COPY app/control/pyproject.toml ./pyproject.toml
COPY app/control/README.md ./README.md
COPY app/control/aionos_control ./aionos_control
COPY app/control/app ./app
COPY app/kernel ./app/kernel

RUN pip install --upgrade pip setuptools wheel \
&& pip install -e .

EXPOSE 8000

CMD ["python", "-m", "app.control.app.main"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Copy full control package into image before running module

The new control image copies only app/control/app into /srv/app/app (lines 11‑15) but the container starts with python -m app.control.app.main. Because the outer app/control package (where app.control is defined) isn’t copied into the image, that module path won’t exist and the container will exit with ModuleNotFoundError: No module named 'app.control'. Copy the entire app/ tree or adjust the entrypoint so the package structure on disk matches the module path.

Useful? React with 👍 / 👎.

Comment thread console/next.config.mjs
Comment on lines +1 to 4
import createTranslator from 'next-intl/server';

const locales = ['en', 'fa'];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import createTranslator as named export

Changing next.config.mjs to import createTranslator from 'next-intl/server' makes createTranslator undefined because next-intl/server exposes it as a named export. When Next.js loads this config it will throw TypeError: createTranslator is not a function, which is already causing pnpm lint to fail. Use the original named import (import { createTranslator } …) or destructure the default to avoid the runtime error.

Useful? React with 👍 / 👎.

@Hamedghz Hamedghz deleted the codex/organize-packaging-and-imports-for-app-mlymmh branch November 11, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant