Add NSCalendarsFullAccessUsageDescription to Info.plist#3860
Open
souljedi wants to merge 1 commit intoHammerspoon:masterfrom
Open
Add NSCalendarsFullAccessUsageDescription to Info.plist#3860souljedi wants to merge 1 commit intoHammerspoon:masterfrom
souljedi wants to merge 1 commit intoHammerspoon:masterfrom
Conversation
Without this key macOS silently refuses to prompt for Calendar access, so Hammerspoon never appears in System Settings → Privacy & Security → Calendars and all calendar-data reads fail. Also adds the legacy NSCalendarsUsageDescription for macOS ≤ 13 compatibility. Fixes Hammerspoon#3803
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
=======================================
Coverage 27.39% 27.40%
=======================================
Files 191 191
Lines 51537 51537
=======================================
+ Hits 14119 14124 +5
+ Misses 37418 37413 -5 🚀 New features to boost your workflow:
|
Author
|
Is there anything i should change? It looks like the timeout for some of the tests may have been to short? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Without
NSCalendarsFullAccessUsageDescriptioninInfo.plist, macOS silently refuses to prompt the user for Calendar access. Hammerspoon never appears in System Settings → Privacy & Security → Calendars, and all calendar-data reads (via AppleScript or EventKit) fail silently.This was reported in #3803.
Fix
Add the two missing privacy usage description keys, following the same wording pattern as the existing
NSCameraUsageDescription,NSMicrophoneUsageDescription, etc. entries:NSCalendarsFullAccessUsageDescription— required on macOS 14+ for full EventKit accessNSCalendarsUsageDescription— legacy key, honoured on macOS ≤ 13Testing
Closes #3803