Don't use System.Diagnostics.CodeAnalysis as it can be conflicting with Hangfire.Annotations

Author: odinserj

Diff for: src/Hangfire.Core/Dashboard/EmbeddedResourceDispatcher.cs

@@ -14,7 +14,6 @@
 // License along with Hangfire. If not, see <http://www.gnu.org/licenses/>.
 
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using System.Threading.Tasks;
 using Hangfire.Annotations;
@@ -52,7 +51,7 @@ protected virtual Task WriteResponse(DashboardResponse response)
             return WriteResource(response, _assembly, _resourceName);
         }
 
-        [SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Context can be potentially accessed in derived classes.")]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Context can be potentially accessed in derived classes.")]
         protected async Task WriteResource(DashboardResponse response, Assembly assembly, string resourceName)
         {
             using (var inputStream = assembly.GetManifestResourceStream(resourceName))

Diff for: src/Hangfire.Core/Dashboard/HtmlHelper.cs

@@ -20,7 +20,6 @@
 using System.Text;
 using Hangfire.Common;
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq.Expressions;
 using System.Reflection;
@@ -31,7 +30,7 @@
 
 namespace Hangfire.Dashboard
 {
-    [SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "We use instance methods in this class for better observability.")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "We use instance methods in this class for better observability.")]
     public class HtmlHelper
     {
         private static readonly Type DisplayNameType;

Diff for: src/Hangfire.Core/Dashboard/RouteCollection.cs

@@ -15,13 +15,12 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Text.RegularExpressions;
 using Hangfire.Annotations;
 
 namespace Hangfire.Dashboard
 {
-    [SuppressMessage("Naming", "CA1711:Identifiers should not have incorrect suffix", Justification = "Public API, can not change in minor versions.")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1711:Identifiers should not have incorrect suffix", Justification = "Public API, can not change in minor versions.")]
     public class RouteCollection
     {
         private readonly List<Tuple<string, IDashboardDispatcher>> _dispatchers

Diff for: src/Hangfire.Core/GlobalConfiguration.cs

@@ -17,13 +17,12 @@
 
 using System;
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using Hangfire.Annotations;
 
 namespace Hangfire
 {
-    [SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "Public API, can not touch in minor versions.")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "Public API, can not touch in minor versions.")]
     public enum CompatibilityLevel
     {
         Version_110 = 110,

Diff for: src/Hangfire.Core/Server/ServerJobCancellationToken.cs

@@ -20,7 +20,6 @@
 using Hangfire.Storage;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Hangfire.Server
@@ -80,7 +79,7 @@ public void Dispose()
             }
         }
 
-        [SuppressMessage("SonarLint", "S4275:GettersAndSettersShouldAccessTheExpectedFields", Justification = "Bad property naming for backwards compatibility.")]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("SonarLint", "S4275:GettersAndSettersShouldAccessTheExpectedFields", Justification = "Bad property naming for backwards compatibility.")]
         public CancellationToken ShutdownToken
         {
             get

Diff for: src/Hangfire.Core/States/StateChangeContext.cs

@@ -15,15 +15,14 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using Hangfire.Annotations;
 using Hangfire.Profiling;
 using Hangfire.Storage;
 
 namespace Hangfire.States
 {
-    [SuppressMessage("Design", "CA1068:CancellationToken parameters must come last", Justification = "Cancellation tokens in this class are used only as a part of a general context and don't have usual meaning.")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1068:CancellationToken parameters must come last", Justification = "Cancellation tokens in this class are used only as a part of a general context and don't have usual meaning.")]
     public class StateChangeContext
     {
         public StateChangeContext(

Diff for: src/Hangfire.Core/States/StateMachine.cs

@@ -15,7 +15,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using Hangfire.Annotations;
 using Hangfire.Common;
 using Hangfire.Profiling;
@@ -46,7 +45,7 @@ internal StateMachine(
 
         public IStateMachine InnerStateMachine => _innerStateMachine;
 
-        [SuppressMessage("Naming", "CA1725:Parameter names should match base declaration", Justification = "Parameter name changed to avoid ambiguity and errors in the method's implementation.")]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1725:Parameter names should match base declaration", Justification = "Parameter name changed to avoid ambiguity and errors in the method's implementation.")]
         public IState ApplyState(ApplyStateContext initialContext)
         {
             if (initialContext == null) throw new ArgumentNullException(nameof(initialContext));