Replacing ContainsKey with TryGetValue to avoid duplicate lookups in … #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odinserj
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Thanks @robink-teleopti for this clean up! out var definitely simplifies the code. Together with avoiding duplicates we are minimizing the risk to use different property names between calls to ContainsKey and using an indexer, for example due to mistyping. So I'm approving the changes.
|
Yes, actually, I didn't mention it, but I think there was a minor bug in the RecurringJobEntity code before my change; |
odinserj
added a commit
that referenced
this pull request
Mar 21, 2019
…empty Described in #1374 (comment) by @robink-teleopti.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dictionaries