WIP: present timing support #2751
Draft
+881
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Also demonstrate present interval > 1. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Benign, but it is invalid. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
present-timing
branch
from
ec76dcb to
897ce11
Compare
|
Will this eventually allow to implement SyncInterval > 1 with proper frame pacing? I believe right now it would use a framelimiter that won't vsync window reliably? It looks like it would require presentAtAbsoluteTimeSupported or presentAtRelativeTimeSupported, so from the current state of https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38770 that means x11/xwayland or a wayland compositor with commit_timing support, is that correct? |
Owner
Author
|
That is the point of this, yes. It's already working on Mesa MR and NV vulkan beta drivers. But won't work in Proton until winevulkan adds proper support for EXT_present_timing. |
HansKristian-Work
force-pushed
the
present-timing
branch
5 times, most recently
from
9079f4f to
bfd85d3
Compare
… their newest iteration. Use present_id2/wait2 when available and KHR_swapchain_maintenance1. Get rid of legacy path where we block on CPU progress in ::Present(). It's completely irrelevant these days since all relevant platforms support KHR_present_wait(2) just fine. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
present-timing
branch
from
bfd85d3 to
e767e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.