Improve RenderPass API handling w.r.t. suspend-resume #2761
+1,050
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
render-pass-improvements
branch
6 times, most recently
from
ad073f9 to
de8d119
Compare
doitsujin
reviewed
Jan 13, 2026
doitsujin
reviewed
Jan 13, 2026
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
render-pass-improvements
branch
from
de8d119 to
15711ed
Compare
We may need to handle clears and kick off the suspend resume as needed. It might be possible to omit it in certain cases, but we're really supposed to do what application says when it's using explicit render pass API. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Similar to deferred clear, but we don't do barrier on deferred discard. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
LOAD_OP_DONT_CARE implies a write, so need writable layouts. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
When the stars align we can promote attachment resolves properly. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Lots of bad state tracking going on here that ended up blocking suspend-resume. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
For resolves, we can potentially only do the resolve when we confirm render pass completion. For EndingAccess DISCARD, we can only safely do that on EndRenderPass. Only do render pass resolves if we confirm load-store-op-compat workaround for simplicity. Ignore DISCARDs if we don't have this compat. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
render-pass-improvements
branch
from
15711ed to
14749af
Compare
Owner
Author
|
Added a comment at the end which deals with independent resolves in a smarter way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.