Skip to content

Clean dead code#832

Merged
HaoboGu merged 1 commit into
mainfrom
refactor/clean
May 5, 2026
Merged

Clean dead code#832
HaoboGu merged 1 commit into
mainfrom
refactor/clean

Conversation

@HaoboGu
Copy link
Copy Markdown
Owner

@HaoboGu HaoboGu commented May 5, 2026

No description provided.

@HaoboGu
refactor: clean dead code
c6d3a2c 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu merged commit a4fd9f2 into main May 5, 2026
43 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Size Report

Example main PR Diff .text .data .bss
use_config/nrf52832_ble 354.6 KiB 354.6 KiB +0.00% ⬆️ +16 0 0
use_config/nrf52840_ble 404.4 KiB 404.4 KiB +0.00% ⬆️ +4 0 0
use_config/nrf52840_ble_split (central) 480.0 KiB 480.0 KiB +0.00% 0 0 0
use_config/nrf52840_ble_split (peripheral) 307.7 KiB 307.7 KiB +0.00% 0 0 0
use_config/pi_pico_w_ble 638.1 KiB 638.1 KiB +0.00% ⬇️ -20 0 0
use_config/rp2040 144.8 KiB 144.8 KiB +0.00% ⬇️ -8 0 0
use_config/rp2040_split (central) 156.6 KiB 156.6 KiB +0.00% ⬇️ -4 0 0
use_config/rp2040_split (peripheral) 25.9 KiB 25.9 KiB -0.01% ⬇️ -4 0 0
use_config/stm32f1 62.2 KiB 62.2 KiB +0.00% ⬆️ +4 0 0
use_config/stm32h7 97.8 KiB 97.8 KiB +0.00% ⬆️ +4 0 0
use_rust/nrf52832_ble 343.7 KiB 343.7 KiB +0.00% 0 0 0
use_rust/nrf52840_ble 399.5 KiB 399.5 KiB +0.00% ⬇️ -4 0 0
use_rust/nrf52840_ble_split (central) 488.0 KiB 488.0 KiB +0.00% ⬆️ +4 0 0
use_rust/nrf52840_ble_split (peripheral) 304.4 KiB 304.4 KiB +0.00% ⬇️ -8 0 0
use_rust/pi_pico_w_ble 638.6 KiB 638.5 KiB +0.00% ⬇️ -48 0 0
use_rust/rp2040 144.5 KiB 144.5 KiB +0.00% ⬇️ -8 0 0
use_rust/rp2040_split (central) 155.9 KiB 155.9 KiB +0.00% ⬆️ +4 0 0
use_rust/rp2040_split (peripheral) 26.4 KiB 26.4 KiB -0.01% ⬇️ -4 0 0
use_rust/stm32f1 61.7 KiB 61.7 KiB +0.00% 0 0 0
use_rust/stm32h7 119.5 KiB 119.5 KiB +0.00% 0 0 0
use_config/nrf52832_ble — 354.6 KiB → 354.6 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 324632	   5192	  33320	 363144	  58a88	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 324616	   5192	  33320	 363128	  58a78	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +64  [ = ]       0    .debug_ranges
  +0.0%     +32  [ = ]       0    .symtab
  +0.0%     +25  [ = ]       0    .strtab
  +0.0%     +20  [ = ]       0    .debug_frame
  +0.0%     +16  +0.0%     +16    .text
  +0.0%      +8  [ = ]       0    .debug_aranges
  -0.2%     -17  [ = ]       0    .debug_abbrev
 -27.5%     -19  [ = ]       0    [Unmapped]
  -0.1%    -262  [ = ]       0    .debug_line
  -0.0% -1.01Ki  [ = ]       0    .debug_str
  -0.2% -1.03Ki  [ = ]       0    .debug_loc
  -0.2% -2.82Ki  [ = ]       0    .debug_info
  -0.1% -4.99Ki  +0.0%     +16    TOTAL
use_config/nrf52840_ble — 404.4 KiB → 404.4 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 358772	   5200	  50096	 414068	  65174	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 358768	   5200	  50096	 414064	  65170	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +5  [ = ]       0    .debug_line
  +0.0%      +4  +0.0%      +4    .text
 -12.5%      -6  [ = ]       0    [Unmapped]
  -0.0%    -206  [ = ]       0    .debug_str
  -0.0%    -221  [ = ]       0    .debug_info
  -0.0%    -424  +0.0%      +4    TOTAL
use_config/nrf52840_ble_split (central) — 480.0 KiB → 480.0 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 439068	   6524	  45904	 491496	  77fe8	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 439068	   6524	  45904	 491496	  77fe8	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +588  [ = ]       0    .debug_str
  +0.0%      +1  [ = ]       0    .debug_loc
  +1.8%      +1  [ = ]       0    [Unmapped]
  -0.0%     -19  [ = ]       0    .debug_line
  -0.0%    -459  [ = ]       0    .debug_info
  +0.0%    +112  [ = ]       0    TOTAL
use_config/nrf52840_ble_split (peripheral) — 307.7 KiB → 307.7 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 282704	   5888	  26520	 315112	  4cee8	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 282704	   5888	  26520	 315112	  4cee8	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -1  [ = ]       0    .debug_loc
  -3.0%      -2  [ = ]       0    [Unmapped]
  -0.0%    -294  [ = ]       0    .debug_info
  -0.0%    -319  [ = ]       0    .debug_str
  -0.0%    -616  [ = ]       0    TOTAL
use_config/pi_pico_w_ble — 638.1 KiB → 638.1 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 598884	      0	  54488	 653372	  9f83c	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 598904	      0	  54488	 653392	  9f850	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +77  [ = ]       0    .debug_line
 -21.7%     -13  [ = ]       0    [Unmapped]
  -0.0%     -20  -0.0%     -20    .text
  -0.0%    -104  [ = ]       0    .debug_ranges
  -0.0%    -249  [ = ]       0    .debug_str
  -0.1%    -856  [ = ]       0    .debug_loc
  -0.0%    -955  [ = ]       0    .debug_info
  -0.0% -2.07Ki  -0.0%     -20    TOTAL
use_config/rp2040 — 144.8 KiB → 144.8 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 133192	      0	  15092	 148284	  2433c	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 133200	      0	  15092	 148292	  24344	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +310  [ = ]       0    .debug_str
  +0.0%    +304  [ = ]       0    .debug_info
  +0.0%     +22  [ = ]       0    .debug_loc
  -0.0%      -8  -0.0%      -8    .text
 -39.4%     -26  [ = ]       0    [Unmapped]
  -0.1%    -114  [ = ]       0    .debug_line
  +0.0%    +488  -0.0%      -8    TOTAL
use_config/rp2040_split (central) — 156.6 KiB → 156.6 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 144500	      0	  15864	 160364	  2726c	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 144504	      0	  15864	 160368	  27270	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +257  [ = ]       0    .debug_str
  +0.0%     +42  [ = ]       0    .debug_loc
  -3.3%      -2  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%     -69  [ = ]       0    .debug_line
  -0.0%    -260  [ = ]       0    .debug_info
  -0.0%     -36  -0.0%      -4    TOTAL
use_config/rp2040_split (peripheral) — 25.9 KiB → 25.9 KiB (-0.01% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  24016	     56	   2412	  26484	   6774	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  24020	     56	   2412	  26488	   6778	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18%      +6  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_str
  -0.1%      -4  -0.1%      -4    .rodata
  [ = ]       0  -0.0%      -4    TOTAL
use_config/stm32f1 — 62.2 KiB → 62.2 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  56272	     28	   7416	  63716	   f8e4	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  56268	     28	   7416	  63712	   f8e0	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +67%     +28  [ = ]       0    [Unmapped]
  +0.0%      +4  +0.0%      +4    .text
  -0.0%     -27  [ = ]       0    .debug_line
  -0.0%     -76  [ = ]       0    .debug_str
  -0.1%    -281  [ = ]       0    .debug_info
  -0.0%    -352  +0.0%      +4    TOTAL
use_config/stm32h7 — 97.8 KiB → 97.8 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  90428	    268	   9464	 100160	  18740	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  90424	    268	   9464	 100156	  1873c	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +521  [ = ]       0    .debug_str
  +0.0%      +4  +0.0%      +4    .text
 -11.4%      -5  [ = ]       0    [Unmapped]
  -0.1%    -171  [ = ]       0    .debug_line
  -0.0%    -461  [ = ]       0    .debug_info
  -0.0%    -112  +0.0%      +4    TOTAL
use_rust/nrf52832_ble — 343.7 KiB → 343.7 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 314408	   5200	  32304	 351912	  55ea8	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 314408	   5200	  32304	 351912	  55ea8	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7%     +58  [ = ]       0    .debug_abbrev
  +3.6%      +2  [ = ]       0    [Unmapped]
  +0.0%      +1  [ = ]       0    .strtab
  -0.0%     -20  [ = ]       0    .debug_info
  -0.0%     -36  [ = ]       0    .debug_line
  -0.0%     -97  [ = ]       0    .debug_str
  -0.0%     -92  [ = ]       0    TOTAL
use_rust/nrf52840_ble — 399.5 KiB → 399.5 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 358296	   5200	  45584	 409080	  63df8	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 358300	   5200	  45584	 409084	  63dfc	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +496  [ = ]       0    .debug_str
  +0.0%    +432  [ = ]       0    .debug_info
  +0.2%     +16  [ = ]       0    .debug_abbrev
  +0.0%      +2  [ = ]       0    .debug_line
  +5.3%      +2  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -14  [ = ]       0    .strtab
  +0.0%    +912  -0.0%      -4    TOTAL
use_rust/nrf52840_ble_split (central) — 488.0 KiB → 488.0 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 441532	   6524	  51648	 499704	  79ff8	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 441528	   6524	  51648	 499700	  79ff4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +69  [ = ]       0    .debug_str
  +0.0%      +4  +0.0%      +4    .text
  -6.6%      -4  [ = ]       0    [Unmapped]
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%     -12  [ = ]       0    .strtab
  -0.0%    -175  [ = ]       0    .debug_info
  -0.4% -1.47Ki  [ = ]       0    .debug_line
  -0.0% -1.59Ki  +0.0%      +4    TOTAL
use_rust/nrf52840_ble_split (peripheral) — 304.4 KiB → 304.4 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 281128	   5328	  25288	 311744	  4c1c0	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 281136	   5328	  25288	 311752	  4c1c8	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +681  [ = ]       0    .debug_str
  +0.0%    +354  [ = ]       0    .debug_info
  +0.0%     +32  [ = ]       0    .debug_loc
   +22%     +11  [ = ]       0    [Unmapped]
  +0.0%      +2  [ = ]       0    .debug_line
  -0.0%      -4  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%      -8  -0.0%      -8    .text
  +0.0% +1.04Ki  -0.0%      -8    TOTAL
use_rust/pi_pico_w_ble — 638.6 KiB → 638.5 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 599224	      0	  54632	 653856	  9fa20	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 599272	      0	  54632	 653904	  9fa50	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +130  [ = ]       0    .debug_str
  +0.0%     +28  [ = ]       0    .debug_line
   +32%     +13  [ = ]       0    [Unmapped]
  -0.0%     -16  [ = ]       0    .debug_aranges
  -0.1%     -28  [ = ]       0    .debug_frame
  -0.0%     -32  [ = ]       0    .symtab
  -0.0%     -48  -0.0%     -48    .text
  -0.1%    -112  [ = ]       0    .debug_ranges
  -0.1%    -170  [ = ]       0    .strtab
  -0.0%    -582  [ = ]       0    .debug_info
  -0.1% -1.02Ki  [ = ]       0    .debug_loc
  -0.0% -1.82Ki  -0.0%     -48    TOTAL
use_rust/rp2040 — 144.5 KiB → 144.5 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 132992	      0	  14972	 147964	  241fc	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 133000	      0	  14972	 147972	  24204	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27%     +11  [ = ]       0    [Unmapped]
  +0.0%      +6  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%      -8  -0.0%      -8    .text
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -62  [ = ]       0    .debug_info
  -0.1%    -128  [ = ]       0    .debug_line
  -0.0%    -581  [ = ]       0    .debug_str
  -0.0%    -780  -0.0%      -8    TOTAL
use_rust/rp2040_split (central) — 155.9 KiB → 155.9 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 144028	      0	  15644	 159672	  26fb8	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 144024	      0	  15644	 159668	  26fb4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +40  [ = ]       0    .debug_line
  +0.0%      +4  +0.0%      +4    .text
  -8.9%      -5  [ = ]       0    [Unmapped]
  -0.0%      -6  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -14  [ = ]       0    .debug_str
  -0.0%     -25  [ = ]       0    .debug_info
  -0.0%     -24  +0.0%      +4    TOTAL
use_rust/rp2040_split (peripheral) — 26.4 KiB → 26.4 KiB (-0.01% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  24316	     56	   2676	  27048	   69a8	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  24320	     56	   2676	  27052	   69ac	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +16%      +9  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .strtab
  -0.1%      -4  -0.1%      -4    .rodata
  -0.1%      -8  [ = ]       0    .debug_aranges
  -0.0%     -36  [ = ]       0    .debug_info
  -0.0%    -199  [ = ]       0    .debug_str
  -0.0%    -240  -0.0%      -4    TOTAL
use_rust/stm32f1 — 61.7 KiB → 61.7 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  55792	     28	   7392	  63212	   f6ec	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  55792	     28	   7392	  63212	   f6ec	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +4.5%      +3  [ = ]       0    [Unmapped]
  -0.0%     -32  [ = ]       0    .debug_line
  -0.1%    -280  [ = ]       0    .debug_info
  -0.1%    -395  [ = ]       0    .debug_str
  -0.0%    -704  [ = ]       0    TOTAL
use_rust/stm32h7 — 119.5 KiB → 119.5 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 106708	    324	  15308	 122340	  1dde4	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 106708	    324	  15308	 122340	  1dde4	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +30  [ = ]       0    .debug_str
  +0.0%     +10  [ = ]       0    .debug_line
  +1.8%      +1  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -87  [ = ]       0    .debug_info
  -0.0%     -56  [ = ]       0    TOTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HaoboGu